fix: Ensure hasComponentType checks fn value
#4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Nov 27, 2024
Comment on lines
-422
to
-430
| const { | ||
| Checklist: _Checklist, | ||
| ChecklistOptionOne: _ChecklistOptionOne, | ||
| ChecklistOptionTwo: _ChecklistOptionTwo, | ||
| ...invalidatedFlow | ||
| } = flowWithInviteToPay; | ||
| invalidatedFlow["_root"].edges?.splice( | ||
| invalidatedFlow["_root"].edges?.indexOf("Checklist"), | ||
| ); |
There was a problem hiding this comment.
This was passing as the checklist was entirely removed, it's now updated to have an incorrect data value.
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
Invite to pay validation is only checking for the presence of a checklist, not a checklist with
proposal.projectTypeset.This means than an invalid flow can be configured, for which payment requests cannot be sent. I hit this when working on a follow up to #4010, see demo below.
main- incorrect behaviourScreen.Recording.2024-11-27.at.18.22.50.mov
What's the cause?
The logic within
hasComponentType()does not actually update thenodeIdsarray - it just maps and filters without reference to the source. As a result thefncheck never actually happens, allowing anyChecklistto pass the test.Pizza - correct behaviour
Flow: https://4014.planx.pizza/testing/test-itp-validation
Screen.Recording.2024-11-27.at.19.18.27.mov